Skip to content

feat: avoid nav item icon animation#455

Merged
drankou merged 1 commit into
mainfrom
make-icon-color-animation-in-nav-instant-eng-4341
Jun 24, 2026
Merged

feat: avoid nav item icon animation#455
drankou merged 1 commit into
mainfrom
make-icon-color-animation-in-nav-instant-eng-4341

Conversation

@drankou

@drankou drankou commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Avoid icon animation in sidebar nav item so it's synced with instant label color change.

Before After
CleanShot 2026-06-24 at 14 00 42 CleanShot 2026-06-24 at 14 00 17

@linear-code

linear-code Bot commented Jun 24, 2026

Copy link
Copy Markdown

ENG-4341

@cla-bot cla-bot Bot added the cla-signed label Jun 24, 2026
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@vercel

vercel Bot commented Jun 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
web Ready Ready Preview, Comment Jun 24, 2026 12:02pm
web-tango Ready Ready Preview, Comment Jun 24, 2026 12:02pm

Request Review

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial one-line CSS tweak removing color from a transition property.

Extended reasoning...

Overview

This PR is a single-line change in src/features/dashboard/sidebar/content.tsx. The class transition-[size,color] is changed to transition-[size] on the sidebar nav item icon. The intent (per the description) is to make the icon's color change instant so it syncs with the already-instant label color change when navigating between sidebar items.

Security risks

None. This is a pure CSS/Tailwind class adjustment with no logic, no user input handling, no auth or data flow touched.

Level of scrutiny

Very low. This is a visual polish/UX change in a presentational component. The before/after screenshots in the description demonstrate the intended behavior, and Vercel preview deployments are ready for both web and web-tango.

Other factors

The bug hunting system found no issues. There are no outstanding reviewer comments to address. The change matches the stated intent exactly and is fully reversible.

@drankou drankou merged commit cc1da58 into main Jun 24, 2026
14 checks passed
@drankou drankou deleted the make-icon-color-animation-in-nav-instant-eng-4341 branch June 24, 2026 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants